list config: useCheckboxes: true checkbox -- selection fails in neo 7.0.6

Hi George,

a good catch, almost took me 10m :)

Let me describe how I debugged it, to get some insights how to do it.

First I checked examples.list.Base, which has a useCheckBoxes option on the right. Worked.

Then I recalled that I was using almost the same code inside the learning section:

Knowing that it should work in general, I just needed to figure out, why neo-selected did not get applied.

Lists are using item ids in the following format: neo-list-1__tobiu

In depth:

    /**
     * @param {Number|String|object} recordOrId
     * @returns {String}
     */
    getItemId(recordOrId) {
        return `${this.id}__${recordOrId.isRecord ? recordOrId[this.getKeyProperty()] : recordOrId}`
    }

/**
 * @param {String} vnodeId
 * @returns {String|Number} itemId
 */
getItemRecordId(vnodeId) {
    let itemId   = vnodeId.split('__')[1],
        {model}  = this.store,
        keyField = model?.getField(model.keyProperty),
        keyType  = keyField?.type?.toLowerCase();

    if (keyType === 'int' || keyType === 'integer') {
        itemId = parseInt(itemId)
    }

    return itemId
}

The important part: ids inside the DOM are always strings. So, when trying to get the record via an recordId, we do need to know if this one is a string (default) or an integer.

And this already was the root cause: inside examples.todoList.version2.TodoListModel, the id field had the invalid type Number.

I will push the fix now.

Follow up idea: it would be nice to decouple useCheckBoxes optionally from selections and just match another boolean record field (new ticket). Maybe i already created this one.

Thanks.

I missed catching the difference of list Base.mjs getItemRecordId returning 1 vs "1" .

In selection/ListModel.mjs : onListClick, view.store.get("1") returns null.

onListClick({ currentTarget }) {
        let {view} = this,
            record;

    if (!view.disableSelection) {
        record = view.store.get(view.getItemRecordId(currentTarget));

        record && this.select(record)
    }
}

So, in 6.10.10, and going back to 4.0.89, the test was for 'integer' or 'number':

      getItemRecordId(vnodeId) {
        let itemId   = vnodeId.split('__')[1],
            model    = this.store.model,
            keyField = model?.getField(model.keyProperty),
            keyType  = keyField?.type.toLowerCase();

    if (keyType === 'integer' || keyType === 'number') {
        itemId = parseInt(itemId);
    }

    return itemId;
}

Prior, in 2019 the test was for number only:

    getItemRecordId(vnodeId) {
        let itemId   = vnodeId.split('__')[1],
            model    = this.store.model,
            keyField = model && model.getField(model.keyProperty);

    if (keyField && keyField.type.toLowerCase() === 'number') {
        itemId = parseInt(itemId);
    }

    return itemId;
}

Why the changes?