LearnNewsExamplesServices
Frontmatter
id5868
titlebutton.Base: polish the ripple effect styling
stateClosed
labels
enhancement
assigneestobiu
createdAtSep 10, 2024, 11:05 PM
updatedAtSep 10, 2024, 11:10 PM
githubUrlhttps://github.com/neomjs/neo/issues/5868
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtSep 10, 2024, 11:10 PM

button.Base: polish the ripple effect styling

Closed v8.1.0 enhancement
tobiu
tobiu commented on Sep 10, 2024, 11:05 PM

i noticed 2 glitches inside the new theme:

  1. the ripple wrapper needs to use the same border radius as the button
  2. we need to add left: 0 and top: 0 to compensate for button paddings => to ensure the overall position is correct

@mxmrtns

tobiu added the enhancement label on Sep 10, 2024, 11:05 PM
tobiu assigned to @tobiu on Sep 10, 2024, 11:05 PM
tobiu referenced in commit 31ec0ea - "button.Base: polish the ripple effect styling #5868" on Sep 10, 2024, 11:06 PM
tobiu closed this issue on Sep 10, 2024, 11:10 PM