LearnNewsExamplesServices
Frontmatter
id5951
titlePortal.view.learn.ContentComponent: missing destroy() logic
stateClosed
labels
enhancement
assigneestobiu
createdAtSep 21, 2024, 4:40 PM
updatedAtSep 21, 2024, 6:26 PM
githubUrlhttps://github.com/neomjs/neo/issues/5951
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtSep 21, 2024, 6:26 PM

Portal.view.learn.ContentComponent: missing destroy() logic

Closed v8.1.0 enhancement
tobiu
tobiu commented on Sep 21, 2024, 4:40 PM

@maxrahder @rwaters:

the logic is creating code.LivePreview instances which will stick in memory forever. while the portal app will never destroy its one instance, we should still aim for creating re-useable components.

i will take care of this one.

tobiu added the enhancement label on Sep 21, 2024, 4:40 PM
tobiu assigned to @tobiu on Sep 21, 2024, 4:40 PM
tobiu cross-referenced by #5952 on Sep 21, 2024, 4:44 PM
tobiu referenced in commit c23ddf9 - "Portal.view.learn.ContentComponent: missing destroy() logic #5951" on Sep 21, 2024, 6:26 PM
tobiu
tobiu Sep 21, 2024, 6:26 PM

Screenshot 2024-09-21 at 18 25 46

tobiu closed this issue on Sep 21, 2024, 6:26 PM