Frontmatter
| id | 5954 |
| title | collection.Base: isItem() has to return true for "object like" items |
| state | Closed |
| labels | bug |
| assignees | tobiu |
| createdAt | Sep 21, 2024, 6:18 PM |
| updatedAt | Sep 21, 2024, 6:24 PM |
| githubUrl | https://github.com/neomjs/neo/issues/5954 |
| author | tobiu |
| commentsCount | 0 |
| parentIssue | null |
| subIssues | [] |
| subIssuesCompleted | 0 |
| subIssuesTotal | 0 |
| blockedBy | [] |
| blocking | [] |
| closedAt | Sep 21, 2024, 6:24 PM |
isItem(value) { return Neo.isObject(value) || Neo.isRecord(value) }the change happened, when introducing
Neo.isRecord()and makingNeo.isObject()super strict to only return true for real objects.collections however can contain neo instances as items, which no longer get recognised.
if the recognition no longer works, removing items will break, which can result in growing memory leaks when frequently removing items.