LearnNewsExamplesServices
Frontmatter
id5957
titlecontainer.Base: afterSetLayout() => always destroy an old layout
stateClosed
labels
enhancement
assigneestobiu
createdAtSep 21, 2024, 10:18 PM
updatedAtSep 21, 2024, 10:24 PM
githubUrlhttps://github.com/neomjs/neo/issues/5957
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtSep 21, 2024, 10:24 PM

container.Base: afterSetLayout() => always destroy an old layout

Closed v8.1.0 enhancement
tobiu
tobiu commented on Sep 21, 2024, 10:18 PM

currently, the destroy() call happens inside the me.rendered check, which does not cover all edge-cases.

tobiu added the enhancement label on Sep 21, 2024, 10:18 PM
tobiu assigned to @tobiu on Sep 21, 2024, 10:18 PM
tobiu referenced in commit bfd3f87 - "container.Base: afterSetLayout() => always destroy an old layout #5957" on Sep 21, 2024, 10:19 PM
tobiu closed this issue on Sep 21, 2024, 10:19 PM
tobiu
tobiu Sep 21, 2024, 10:23 PM

ha, forgot one edge case: an old layout could still be a config object, so at this point it would not have a destroy() method (and we don't need to adjust things).

tobiu reopened this issue on Sep 21, 2024, 10:23 PM
tobiu referenced in commit ab2fe29 - "#5957 container.Base: afterSetLayout() => always destroy an old layout => ignore config based old values" on Sep 21, 2024, 10:24 PM
tobiu closed this issue on Sep 21, 2024, 10:24 PM