LearnNewsExamplesServices
Frontmatter
id5999
titlePortal App: Home => Features Section Changes cleanup
stateClosed
labels
enhancement
assigneestobiu
createdAtOct 1, 2024, 11:22 PM
updatedAtOct 2, 2024, 2:08 PM
githubUrlhttps://github.com/neomjs/neo/issues/5999
authortobiu
commentsCount7
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtOct 2, 2024, 2:08 PM

Portal App: Home => Features Section Changes cleanup

Closed v8.1.0 enhancement
tobiu
tobiu commented on Oct 1, 2024, 11:22 PM

@VedantDewangan: Tagging you here, so that you can follow what I will change.

Let's start with the alphabet rule order and using 4 spaces.

tobiu added the enhancement label on Oct 1, 2024, 11:22 PM
tobiu assigned to @tobiu on Oct 1, 2024, 11:22 PM
tobiu referenced in commit 011ed9c - "#5999 Portal App Home Features: 4 spaces, alphabetical order" on Oct 1, 2024, 11:23 PM
tobiu
tobiu Oct 1, 2024, 11:26 PM

removing the custom font-family next

tobiu referenced in commit 46cded9 - "#5999 Portal App Home Features: remove the custom font-family" on Oct 1, 2024, 11:26 PM
tobiu
tobiu Oct 1, 2024, 11:33 PM

In case you want to change display: grid to display: flex inside Portal.view.home.parts.Features, this does require a small change on the JS side.

Containers provide layouts to enable defining specific layout attributes on the JS side, if preferred.

  • We can do a workshop session on this topic
  • A dedicated page inside the learning section about container layouts would be good @maxrahder

In case we do not wish to use a container layout, we can set it to base inside the JS code => then the CSS is fully in charge.

tobiu referenced in commit a383571 - "#5999 Portal App Home Features: base layout to support the custom flexbox styling" on Oct 1, 2024, 11:33 PM
tobiu
tobiu Oct 1, 2024, 11:47 PM

removing the !important flags now (not needed, tested it).

tobiu referenced in commit d4ec4d5 - "#5999 Portal App Home Features, ContentBox: removing the !important flags" on Oct 1, 2024, 11:47 PM
tobiu
tobiu Oct 1, 2024, 11:50 PM

inside the ContentBox.scss, there is a non-existing selector => .portal-content-box-lists.

you added the same rules inside .portal-content-box-content li, so i will remove the redundant definition.

tobiu referenced in commit 821a480 - "#5999 Portal App Home ContentBox: removing .portal-content-box-lists (covered via .portal-content-box-content li)" on Oct 1, 2024, 11:51 PM
tobiu
tobiu Oct 2, 2024, 12:11 AM

further testing: the h3 rules will actually get overridden by a more specific selector. we can fix this with changing .portal-content-box-headline to h3.portal-content-box-headline.

now our selector is more specific and we don't need !important.

i will also change the transition timing function from ease to ease-out => then we get a more direct feedback when moving the mouse fast.

tobiu referenced in commit 217a793 - "#5999 Portal App Home ContentBox: timing function => ease-out, more specific headline selector" on Oct 2, 2024, 12:12 AM
tobiu
tobiu Oct 2, 2024, 12:28 AM

we do have 2 remaining issues. might be worth it to create follow-up tickets.

first one is that for big widths, we do lose the symmetric box positioning.

old version:

Screenshot 2024-10-02 at 00 20 06

new version:

Screenshot 2024-10-02 at 00 19 48

obviously the new version looks better in general, but the flex layout can lead to 4 boxes at the top and 2 at the bottom (or 5 top, 1 bottom), while the grid layout can ensure that there are 3 columns max. i will play with this more soon, might be worth it to switch back to the grid.

the 2nd issue is more complicated. for desktop, we do have a custom "scrolling timeline", so that when we scroll (also with using the arrow up / down keys), you will move to the next "page". this requires, that each page can fit on a screen (the content height must not be higher than the viewport).

tobiu referenced in commit 356553b - "#5999 Portal App Home Features: re-added the grid layout, several styling tweaks" on Oct 2, 2024, 2:05 PM
tobiu
tobiu Oct 2, 2024, 2:08 PM

re-added the grid layout and tweaked the responsive styling:

Screenshot 2024-10-02 at 13 57 36

@VedantDewangan: i did try my best to preserve your design changes as good as possible. Also kept the custom scrollbar styling for 1 row grids.

tobiu closed this issue on Oct 2, 2024, 2:08 PM