LearnNewsExamplesServices
Frontmatter
id6034
titleScroll Dead end
stateClosed
labels
bug
assignees[]
createdAtOct 17, 2024, 9:12 AM
updatedAtOct 22, 2024, 1:08 PM
githubUrlhttps://github.com/neomjs/neo/issues/6034
authoruditjainstjis
commentsCount2
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtOct 22, 2024, 1:08 PM

Scroll Dead end

Closed v8.1.0 bug
uditjainstjis
uditjainstjis commented on Oct 17, 2024, 9:12 AM

On site there are two code snippet boxes, when we scroll through website scrolling is working fine, but when our mouse is in code canvas area which is very big webpage doesn't scroll, (this is because when mouse gets inside code canvas it can now scroll code snippet lines only which is the bug, when no much lines of code is present such that scroll is needed it is still changing scroll from webpage to canvas)

and this will stuck users as a dead end due to glitch.

I am already working on this, can you pls assign me this project and add hacktoberfest tag if possible, thanks. https://drive.google.com/file/d/1qXOt-sgG2hV6FdJ2w5E2HE6qgfQj4n6v/view?usp=sharing

uditjainstjis added the bug label on Oct 17, 2024, 9:12 AM
tobiu
tobiu Oct 17, 2024, 12:15 PM

hi @uditjainstjis,

the "code snippets" are a wrapper component for the monaco editor (same engine as in VSCode). By default, scroll events get stopped to keep the "IDE box" at the same spot. I just googled for it and there is a 1-liner config to change it: https://github.com/microsoft/monaco-editor/issues/1853#issuecomment-593484147

We can just drop this one into the component class as the default value, to ensure that the component behaves the same way inside all spots (e.g. learning section).

i can push a quick PoC to demonstrate it. i guess you would need a new ticket for the hacktoberfest then though.

best regards, tobias

tobiu referenced in commit 620d17e - "#6034 component.wrapper.MonacoEditor: added scrollbar: {alwaysConsumeMouseWheel: false} as a default option" on Oct 17, 2024, 12:16 PM
tobiu
tobiu Oct 22, 2024, 1:08 PM

the fix is already deployed to the website.

tobiu closed this issue on Oct 22, 2024, 1:08 PM