LearnNewsExamplesServices
Frontmatter
id6120
titlecomponent.Base: hide() & show()
stateClosed
labels
bug
assigneestobiu
createdAtNov 19, 2024, 1:51 AM
updatedAtNov 19, 2024, 1:52 AM
githubUrlhttps://github.com/neomjs/neo/issues/6120
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtNov 19, 2024, 1:52 AM

component.Base: hide() & show()

Closed v8.1.0 bug
tobiu
tobiu commented on Nov 19, 2024, 1:51 AM

I just noticed that inside v8, switching tabs inside the LivePreview no longer hides & shows the "open in new window" button at the top right corner.

the reason is the following logic:

me.vdom.removeDom = true;
me.parent.update()

while a parent update is reasonable, it now needs to increase the depth by one, since the removeDom flag of the child is no longer present inside the scoped vdom otherwise:

me.vdom.removeDom = true;
me.parent.updateDepth = 2;
me.parent.update()
tobiu added the bug label on Nov 19, 2024, 1:51 AM
tobiu assigned to @tobiu on Nov 19, 2024, 1:51 AM
tobiu referenced in commit 108478f - "component.Base: hide() & show() #6120" on Nov 19, 2024, 1:51 AM
tobiu closed this issue on Nov 19, 2024, 1:52 AM