LearnNewsExamplesServices
Frontmatter
id6240
titlelearneo tutorial todoList: VdomUtil.findVdomChild is not a function
stateClosed
labels
bug
assigneestobiu
createdAtJan 15, 2025, 3:54 PM
updatedAtJan 16, 2025, 3:19 PM
githubUrlhttps://github.com/neomjs/neo/issues/6240
authorgplanansky
commentsCount4
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtJan 16, 2025, 3:18 PM

learneo tutorial todoList: VdomUtil.findVdomChild is not a function

Closed v8.5.0 bug
gplanansky
gplanansky commented on Jan 15, 2025, 3:54 PM

VM102:96 Uncaught TypeError: VdomUtil.findVdomChild is not a function

fix -> change to just "find" (see e.g.examples/todoList/version1/MainComponent.mjs) :

$ pwd
.../neo/resources/data/deck/learnneo/pages/tutorials
$ diff TodoList.md TodoList.md.orig 
94c94
<             node   = VdomUtil.find(me.vdom, data.path[0].id).vdom;
---
>             node   = VdomUtil.findVdomChild(me.vdom, data.path[0].id).vdom;
gplanansky added the bug label on Jan 15, 2025, 3:54 PM
gplanansky
gplanansky Jan 15, 2025, 4:02 PM

Also:

$ pwd
.../neo

$ rg findVdomChild resources/data/deck/training/pages/2023-02-05T17-44-53-815Z.md 80: Neo.util.VDom.findVdomChild(view.vdom, 'title').vdom.innerHTML = business.title; 89: findVdomChild = Neo.util.VDom.findVdomChild 94:findVdomChild = Neo.util.VDom.findVdomChild; 99: this.findVdomChild(view.vdom, 'title').vdom.innerHTML = business.title; 132: this.findVdomChild(view.vdom, 'thumbnail').vdom.src = business.imageUrl; 187: this.findVdomChild(view.vdom, 'address').vdom.cn = business

gplanansky closed this issue on Jan 15, 2025, 4:02 PM
tobiu
tobiu Jan 15, 2025, 7:09 PM

Hi George,

be careful with the Buttons in GitHub. When writing a comment, there is Comment and Close with Comment. I will re-open this ticket for you.

Do you want to send a PR or shall I fix it?

Best regards, Tobi

tobiu reopened this issue on Jan 15, 2025, 7:09 PM
tobiu assigned to @tobiu on Jan 16, 2025, 3:17 PM
tobiu
tobiu Jan 16, 2025, 3:18 PM

i will grab it, to get it into the next release.

tobiu referenced in commit ec387cd - "learneo tutorial todoList: VdomUtil.findVdomChild is not a function #6240" on Jan 16, 2025, 3:18 PM
gplanansky
gplanansky Jan 16, 2025, 3:18 PM

ahh, I sought to close my comment, not the issue. please fix thanks I see you have even as I wrote this.

tobiu closed this issue on Jan 16, 2025, 3:18 PM