LearnNewsExamplesServices
Frontmatter
id6292
titlecomponent.Base, container.Base: afterSetTheme()
stateClosed
labels
enhancement
assigneestobiu
createdAtJan 25, 2025, 9:44 PM
updatedAtJan 25, 2025, 9:45 PM
githubUrlhttps://github.com/neomjs/neo/issues/6292
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtJan 25, 2025, 9:45 PM

component.Base, container.Base: afterSetTheme()

Closed v8.9.0 enhancement
tobiu
tobiu commented on Jan 25, 2025, 9:44 PM

I just noticed the following, when assigning a new theme to a dialog:

Image

  • Containers need to forward theme changes to their children
  • form.field.Picker already forwards it to the Picker
  • Since themes already get inherited on DOM level, we only need to apply it in case the value does not match the parent theme (less update() calls)
tobiu added the enhancement label on Jan 25, 2025, 9:44 PM
tobiu assigned to @tobiu on Jan 25, 2025, 9:44 PM
tobiu referenced in commit 498c150 - "component.Base, container.Base: afterSetTheme() #6292" on Jan 25, 2025, 9:44 PM
tobiu
tobiu Jan 25, 2025, 9:45 PM

Image

tobiu closed this issue on Jan 25, 2025, 9:45 PM