LearnNewsExamplesServices
Frontmatter
id6343
titleselection.grid.RowModel: update record based annotations (in case they exist) on manual selections
stateClosed
labels
enhancement
assigneestobiu
createdAtJan 30, 2025, 1:20 PM
updatedAtJan 30, 2025, 2:30 PM
githubUrlhttps://github.com/neomjs/neo/issues/6343
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtJan 30, 2025, 2:30 PM

selection.grid.RowModel: update record based annotations (in case they exist) on manual selections

Closed v8.13.0 enhancement
tobiu
tobiu commented on Jan 30, 2025, 1:20 PM

@gplanansky

We have the logic in place that annotations update the view (including run-time changes), but the other direction is missing.

This can lead to side effects:

https://github.com/user-attachments/assets/826166f7-104d-4a6f-9c01-2cc85ccc9817

=> Rich is selected as an annotation, I select Gerard manually. Re-sorting the Grid => the selection model contains Gerard, but Rich is still inside the annotations, so both get selected.

tobiu added the enhancement label on Jan 30, 2025, 1:20 PM
tobiu assigned to @tobiu on Jan 30, 2025, 1:20 PM
tobiu referenced in commit dc5a8bd - "selection.grid.RowModel: update record based annotations (in case they exist) on manual selections #6343" on Jan 30, 2025, 2:28 PM
tobiu
tobiu Jan 30, 2025, 2:30 PM

https://github.com/user-attachments/assets/8854266f-4d7b-475a-bd52-68a813b7c432

clicks & key nav will now update the annotations as needed.

tobiu closed this issue on Jan 30, 2025, 2:30 PM
tobiu cross-referenced by #6347 on Jan 30, 2025, 5:10 PM