LearnNewsExamplesServices
Frontmatter
id6368
titlecomponent.Base: #executeVdomUpdate() => remove the vdom & vnode params
stateClosed
labels
enhancement
assigneestobiu
createdAtFeb 3, 2025, 7:28 PM
updatedAtFeb 3, 2025, 7:28 PM
githubUrlhttps://github.com/neomjs/neo/issues/6368
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtFeb 3, 2025, 7:28 PM

component.Base: #executeVdomUpdate() => remove the vdom & vnode params

Closed v8.14.0 enhancement
tobiu
tobiu commented on Feb 3, 2025, 7:28 PM

The params were intended for sub-updates, which never got implemented and are probably not needed.

I did run into edge-case issues, where the vnode got cloned and an outdated version got sent to the worker.

  • update() needs to get rid of the params too
  • promiseUpdate() needs to get rid of the vdom & vnode params
  • wrapper class changes must not use the main thread shortcut
tobiu added the enhancement label on Feb 3, 2025, 7:28 PM
tobiu assigned to @tobiu on Feb 3, 2025, 7:28 PM
tobiu referenced in commit 9a566b4 - "component.Base: #executeVdomUpdate() => remove the vdom & vnode params #6368" on Feb 3, 2025, 7:28 PM
tobiu closed this issue on Feb 3, 2025, 7:28 PM