LearnNewsExamplesServices
Frontmatter
id6499
titlevdom.Helper: createDeltas() => same node check via compentId flag
stateClosed
labels
bug
assigneestobiu
createdAtFeb 26, 2025, 8:23 PM
updatedAtFeb 26, 2025, 8:51 PM
githubUrlhttps://github.com/neomjs/neo/issues/6499
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtFeb 26, 2025, 8:51 PM

vdom.Helper: createDeltas() => same node check via compentId flag

Closed v8.26.0 bug
tobiu
tobiu commented on Feb 26, 2025, 8:23 PM
  • I just noticed that in case we update a TabContainer with a depth of 1, we get deltas for the 3 child items (bar, strip, content container) to move to the same indexes
  • Nothing bad will happen, since they stay at the same spot (no-op)
  • But still, those deltas should not exist in the first place, which we can resolve via enhancing the same node check
tobiu added the bug label on Feb 26, 2025, 8:23 PM
tobiu assigned to @tobiu on Feb 26, 2025, 8:23 PM
tobiu referenced in commit 2585b12 - "vdom.Helper: createDeltas() => same node check via compentId flag #6499" on Feb 26, 2025, 8:24 PM
tobiu closed this issue on Feb 26, 2025, 8:28 PM
tobiu
tobiu Feb 26, 2025, 8:49 PM

I need to reopen this one, since the new check needs to exclude non-set componentId flags (both sides undefined)

tobiu reopened this issue on Feb 26, 2025, 8:49 PM
tobiu referenced in commit f494eb9 - "vdom.Helper: createDeltas() => same node check via componentId flag #6499" on Feb 26, 2025, 8:50 PM
tobiu closed this issue on Feb 26, 2025, 8:51 PM