LearnNewsExamplesServices
Frontmatter
id6696
titlecontainer.Base: afterSetLayout()
stateClosed
labels
enhancement
assigneestobiu
createdAtMay 5, 2025, 3:43 PM
updatedAtMay 5, 2025, 7:22 PM
githubUrlhttps://github.com/neomjs/neo/issues/6696
authortobiu
commentsCount0
parentIssuenull
subIssues
6697 layout.Base: applyRenderAttributes() => should trigger applyChildAttributes() internally
6698 layout.Base: removeRenderAttributes() => should trigger removeChildAttributes() internally
6699 layout.Cube: destroy() => move the transformation logic into removeRenderAttributes()
6700 Portal.view.ViewportController: setMainContentIndex() => only use the first timeout for cube layout switches
6701 layout.Base: applyRenderAttributes() => add a silent param
6702 layout.Cube: getPlaneId()
subIssuesCompleted6
subIssuesTotal6
blockedBy[]
blocking[]
closedAtMay 5, 2025, 7:22 PM

container.Base: afterSetLayout()

Closed v9.0.1 enhancement
tobiu
tobiu commented on May 5, 2025, 3:43 PM

so far, container.Base is using:

afterSetLayout(value, oldValue) {
    let me = this;

    if (me.rendered) {
        oldValue?.removeRenderAttributes();
        value?.applyRenderAttributes();

        me.items.forEach((item, index) => {
            oldValue?.removeChildAttributes(item, index);
            value?.applyChildAttributes(item, index)
        })
    }

    oldValue?.destroy?.()
}
  • There should just be one layout method call (layouts can iterate over items internally)
  • The cube layout contains logic on destruction, which happens after new layout child attributes got applied). this worked in v8, but breaks for card to cube changes in v9
tobiu assigned to @tobiu on May 5, 2025, 3:43 PM
tobiu added the enhancement label on May 5, 2025, 3:43 PM
tobiu added sub-issue #6697 on May 5, 2025, 3:44 PM
tobiu added sub-issue #6698 on May 5, 2025, 3:45 PM
tobiu added sub-issue #6699 on May 5, 2025, 4:07 PM
tobiu added sub-issue #6700 on May 5, 2025, 4:17 PM
tobiu added sub-issue #6701 on May 5, 2025, 6:54 PM
tobiu added sub-issue #6702 on May 5, 2025, 7:19 PM
tobiu closed this issue on May 5, 2025, 7:22 PM