LearnNewsExamplesServices
Frontmatter
id6987
titlev10 harden core.Base#afterSetId()
stateClosed
labels
enhancement
assigneestobiu
createdAtJul 8, 2025, 5:54 PM
updatedAtJul 8, 2025, 5:55 PM
githubUrlhttps://github.com/neomjs/neo/issues/6987
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtJul 8, 2025, 5:55 PM

v10 harden core.Base#afterSetId()

Closed v10.0.0-beta.5 enhancement
tobiu
tobiu commented on Jul 8, 2025, 5:54 PM
  • It should use value instead of this.id to avoid using using the config atom getter
  • oldValue should check for the existence of Neo.idMap

While oldValue attempts => having a value without an idMap is a theoretical problem => could only happen in case Neo.setupClass() had bugs, the check is still reasonable.

tobiu assigned to @tobiu on Jul 8, 2025, 5:54 PM
tobiu added the enhancement label on Jul 8, 2025, 5:54 PM
tobiu referenced in commit 951f581 - "v10 harden core.Base#afterSetId() #6987" on Jul 8, 2025, 5:55 PM
tobiu closed this issue on Jul 8, 2025, 5:55 PM
tobiu referenced in commit 16f3c3a - "v10 harden core.Base#afterSetId() #6987" on Jul 9, 2025, 2:10 AM