LearnNewsExamplesServices
Frontmatter
id7098
titleutil.vdom.TreeBuilder: #buildTree()
stateClosed
labels
enhancement
assigneestobiu
createdAtJul 22, 2025, 5:22 PM
updatedAtJul 22, 2025, 9:30 PM
githubUrlhttps://github.com/neomjs/neo/issues/7098
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtJul 22, 2025, 9:30 PM

util.vdom.TreeBuilder: #buildTree()

Closed v10.0.0 enhancement
tobiu
tobiu commented on Jul 22, 2025, 5:22 PM
  • Keep it DRY.
  • Make the intent more clear: showcasing that we want to aggregate vdom & vnode trees in the same way.
tobiu assigned to @tobiu on Jul 22, 2025, 5:22 PM
tobiu added the enhancement label on Jul 22, 2025, 5:22 PM
tobiu referenced in commit 8d36325 - "util.vdom.TreeBuilder: #buildTree() #7098" on Jul 22, 2025, 5:22 PM
tobiu closed this issue on Jul 22, 2025, 5:23 PM
tobiu
tobiu Jul 22, 2025, 9:30 PM

we are facing an edge case, only inside the unit testing realm.

the combined logic contained the if (!Neo.isObject(node) {return node} check also for vnodes, which was previously only there for vdom.

inside the unit testing scope, we import vdom.Helper into main threads, so vnodes are no longer objects, and the new method opted out right away.

tobiu reopened this issue on Jul 22, 2025, 9:30 PM
tobiu referenced in commit 112400c - "util.vdom.TreeBuilder: #buildTree() #7098" on Jul 22, 2025, 9:30 PM
tobiu closed this issue on Jul 22, 2025, 9:30 PM