LearnNewsExamplesServices
Frontmatter
id7293
titleConvert vdom/layout/Cube.mjs Test from Siesta to Playwright
stateClosed
labels
enhancementhelp wantedgood first issuehacktoberfest
assigneeskart-u
createdAtSep 27, 2025, 4:07 PM
updatedAtOct 4, 2025, 8:47 PM
githubUrlhttps://github.com/neomjs/neo/issues/7293
authortobiu
commentsCount6
parentIssue7262
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtOct 4, 2025, 7:58 PM

Convert vdom/layout/Cube.mjs Test from Siesta to Playwright

Closed v11.0.0 enhancementhelp wantedgood first issuehacktoberfest
tobiu
tobiu commented on Sep 27, 2025, 4:07 PM

This task is to migrate the unit test for vdom/layout/Cube.mjs from the Siesta test harness to the Playwright test runner.

Acceptance Criteria

  1. Create a new test file at test/playwright/unit/vdom/layout/Cube.spec.mjs.
  2. Translate all assertions from the original file (test/siesta/tests/vdom/layout/Cube.mjs) to the Playwright/Jest expect syntax.
  3. Ensure the new test runs successfully via npm test.
  4. The new test must cover all the functionality of the original Siesta test.
tobiu added the enhancement label on Sep 27, 2025, 4:07 PM
tobiu added parent issue #7262 on Sep 27, 2025, 4:07 PM
tobiu added the help wanted label on Oct 2, 2025, 9:21 PM
tobiu added the good first issue label on Oct 2, 2025, 9:21 PM
tobiu added the hacktoberfest label on Oct 2, 2025, 9:21 PM
tobiu
tobiu Oct 3, 2025, 6:24 PM

Ha, these 2 comments came in almost at the same time. Assuming you are not the same person, I would stick to "first comment wins". I hope this is fine, since both of you already have other tickets assigned.

No worries, I can easily create more new tickets if needed.

tobiu assigned to @kart-u on Oct 3, 2025, 6:24 PM
tobiu referenced in commit 705865e - "Convert vdom/layout/Cube.mjs Test from Siesta to Playwright #7293" on Oct 4, 2025, 7:58 PM
tobiu referenced in commit 79bb918 - "Convert vdom/layout/Cube.mjs Test from Siesta to Playwright #7293" on Oct 4, 2025, 7:58 PM
tobiu referenced in commit 2e770aa - "Convert vdom/layout/Cube.mjs Test from Siesta to Playwright #7293" on Oct 4, 2025, 7:58 PM
tobiu closed this issue on Oct 4, 2025, 7:58 PM
tobiu referenced in commit ce0b439 - "Convert vdom/layout/Cube.mjs Test from Siesta to Playwright #7293" on Oct 4, 2025, 7:58 PM
tobiu
tobiu Oct 4, 2025, 8:31 PM

reopening, since something is off with the imports / top-level setup. only happens when running all tests combined.

tobiu referenced in commit f03427b - "#7293 ticket md file update, imports / setup fix" on Oct 4, 2025, 8:31 PM
tobiu
tobiu Oct 4, 2025, 8:47 PM

the PR was already merged. somehow the combination of the cube layout and vdomrealword tests clashed. now all 114 tests are passing.