LearnNewsExamplesServices
Frontmatter
id7294
titleConvert vdom/table/Container.mjs Test from Siesta to Playwright
stateClosed
labels
enhancementhelp wantedgood first issuehacktoberfest
assigneesKURO-1125
createdAtSep 27, 2025, 4:09 PM
updatedAtOct 2, 2025, 9:54 PM
githubUrlhttps://github.com/neomjs/neo/issues/7294
authortobiu
commentsCount7
parentIssue7262
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtOct 2, 2025, 9:54 PM

Convert vdom/table/Container.mjs Test from Siesta to Playwright

Closed v11.0.0 enhancementhelp wantedgood first issuehacktoberfest
tobiu
tobiu commented on Sep 27, 2025, 4:09 PM

This task is to migrate the unit test for vdom/table/Container.mjs from the Siesta test harness to the Playwright test runner.

Acceptance Criteria

  1. Create a new test file at test/playwright/unit/vdom/table/Container.spec.mjs.
  2. Translate all assertions from the original file (test/siesta/tests/vdom/table/Container.mjs) to the Playwright/Jest expect syntax.
  3. Ensure the new test runs successfully via npm test.
  4. The new test must cover all the functionality of the original Siesta test.
tobiu added the enhancement label on Sep 27, 2025, 4:09 PM
tobiu added parent issue #7262 on Sep 27, 2025, 4:09 PM
tobiu added the help wanted label on Sep 29, 2025, 4:53 PM
tobiu added the good first issue label on Sep 29, 2025, 4:53 PM
tobiu added the hacktoberfest label on Sep 29, 2025, 4:53 PM
tobiu
tobiu Oct 2, 2025, 7:30 PM

Hi and thanks for the interest. For this ticket, I strongly recommend to try out the "ai native" workflow: https://github.com/neomjs/neo/blob/dev/.github/WORKING_WITH_AGENTS.md https://github.com/neomjs/neo/blob/dev/.github/AI_QUICK_START.md

=> Gemini was able to rush through several migrations without any help.

Image
Image

Of course you can also do it manually, but it feels a bit like wasting time here.

tobiu assigned to @KURO-1125 on Oct 2, 2025, 7:30 PM
tobiu cross-referenced by #7285 on Oct 2, 2025, 7:33 PM
tobiu
tobiu Oct 2, 2025, 9:18 PM

Thanks for the feedback! I am still polishing the new memory core (other pinned epic). the code is already done, i just need to add the documentation. Inside the Github page of your fork, there is a pull request button. Then you can send the PR to the neo dev branch, and i will add the hacktoberfest-accepted label and merge it in.

tobiu
tobiu Oct 2, 2025, 9:19 PM

i should add: ideally one PR for each sub, so that both count for the event.

tobiu
tobiu Oct 2, 2025, 9:20 PM

i will flag more of the testing subs with the hacktoberfest label now.

  • 2025-10-02T19:31:27Z @KURO-1125 cross-referenced by PR #7330

@KURO-1125 - 2025-10-02T19:33:24Z

Perfect! I've created two separate PRs as requested:

  1. vdom/table/Container migration: migrate-vdom-table-container branch
  2. neo/MixinStaticConfig migration: migrate-neo-mixin-static-config branch

Thanks for flagging more test migration issues with the hacktoberfest label!

tobiu closed this issue on Oct 2, 2025, 9:54 PM