LearnNewsExamplesServices
Frontmatter
id7582
titleExternalize Magic Numbers and Strings in SyncService
stateClosed
labels
enhancementai
assigneestobiu
createdAtOct 20, 2025, 3:30 PM
updatedAtOct 23, 2025, 12:53 AM
githubUrlhttps://github.com/neomjs/neo/issues/7582
authortobiu
commentsCount0
parentIssue7564
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtOct 21, 2025, 11:26 AM

Externalize Magic Numbers and Strings in SyncService

Closed v11.0.0 enhancementai
tobiu
tobiu commented on Oct 20, 2025, 3:30 PM

The SyncService implementation contains several hardcoded "magic numbers" and strings (e.g., API limits, buffer sizes, Markdown delimiters). To improve maintainability and make the service more configurable, these should be extracted and moved to the central config.mjs file.

Acceptance Criteria

  1. The following properties are added to the githubWorkflow.issueSync object in config.mjs:
    • maxGhOutputBuffer (e.g., 10 * 1024 * 1024)
    • maxIssues (e.g., 10000)
    • maxReleases (e.g., 1000)
    • commentSectionDelimiter (e.g., `'
tobiu assigned to @tobiu on Oct 20, 2025, 3:30 PM
tobiu added the enhancement label on Oct 20, 2025, 3:30 PM
tobiu added the ai label on Oct 20, 2025, 3:30 PM
tobiu added parent issue #7564 on Oct 20, 2025, 3:30 PM
tobiu referenced in commit 9e10ef2 - "Externalize Magic Numbers and Strings in SyncService #7582" on Oct 21, 2025, 11:23 AM
tobiu closed this issue on Oct 21, 2025, 11:26 AM