LearnNewsExamplesServices
Frontmatter
id7584
titleFix Semantic Version Comparison in HealthService using 'semver'
stateClosed
labels
bugai
assigneestobiu
createdAtOct 20, 2025, 3:47 PM
updatedAtOct 20, 2025, 3:55 PM
githubUrlhttps://github.com/neomjs/neo/issues/7584
authortobiu
commentsCount0
parentIssue7564
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtOct 20, 2025, 3:55 PM

Fix Semantic Version Comparison in HealthService using 'semver'

Closed v11.0.0 bugai
tobiu
tobiu commented on Oct 20, 2025, 3:47 PM

The HealthService.#checkGhVersion() method currently uses string comparison (>=) to check if the installed gh CLI version meets the minimum requirement. This is a critical bug that breaks for semantic versioning (e.g., "2.9.0" incorrectly compares as greater than "2.10.0").

This will be fixed by incorporating the official semver npm package.

Acceptance Criteria

  1. The semver package is added as a devDependency to package.json.
  2. npm install is run to update the node_modules directory.
  3. HealthService.mjs is updated to import the semver package.
  4. The #checkGhVersion() method is refactored to use semver.gte(currentVersion, minVersion) for the version comparison instead of the incorrect string comparison.
tobiu assigned to @tobiu on Oct 20, 2025, 3:47 PM
tobiu added parent issue #7564 on Oct 20, 2025, 3:47 PM
tobiu added the bug label on Oct 20, 2025, 3:47 PM
tobiu added the ai label on Oct 20, 2025, 3:47 PM
tobiu referenced in commit 37809d6 - "Fix Semantic Version Comparison in HealthService using 'semver' #7584" on Oct 20, 2025, 3:54 PM
tobiu closed this issue on Oct 20, 2025, 3:55 PM