LearnNewsExamplesServices
Frontmatter
id7720
titleRefactor: Inline `healthHelpers.mjs` into `HealthService.mjs`
stateClosed
labels
airefactoring
assignees[]
createdAtNov 8, 2025, 10:50 AM
updatedAtNov 11, 2025, 9:35 AM
githubUrlhttps://github.com/neomjs/neo/issues/7720
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtNov 11, 2025, 9:35 AM

Refactor: Inline healthHelpers.mjs into HealthService.mjs

Closed v11.1.0 airefactoring
tobiu
tobiu commented on Nov 8, 2025, 10:50 AM

The healthHelpers.mjs file was introduced in PR #7717 to separate parsing logic from HealthService.mjs. However, this logic is not shared with any other module, and the file itself is quite short. To simplify the architecture, the helper functions (combineOutput, parseAuthOutput, parseVersionOutput, interpretExecError) should be moved back into HealthService.mjs as private methods, and the healthHelpers.mjs file should be deleted. The associated test file healthHelpers.test.mjs should also be either removed or its tests integrated into a test for HealthService.mjs.

tobiu added the ai label on Nov 8, 2025, 10:50 AM
tobiu added the refactoring label on Nov 8, 2025, 10:50 AM
tobiu cross-referenced by PR #7717 on Nov 8, 2025, 11:03 AM
MannXo cross-referenced by PR #7738 on Nov 11, 2025, 9:01 AM
tobiu closed this issue on Nov 11, 2025, 9:35 AM