Frontmatter
| id | 7736 |
| title | Refactor: Remove unnecessary try/catch blocks in HealthService |
| state | Closed |
| labels | airefactoring |
| assignees | tobiu |
| createdAt | Nov 10, 2025, 9:19 PM |
| updatedAt | Nov 10, 2025, 9:20 PM |
| githubUrl | https://github.com/neomjs/neo/issues/7736 |
| author | tobiu |
| commentsCount | 0 |
| parentIssue | null |
| subIssues | [] |
| subIssuesCompleted | 0 |
| subIssuesTotal | 0 |
| blockedBy | [] |
| blocking | [] |
| closedAt | Nov 10, 2025, 9:20 PM |
The
HealthServicein thegithub-workflowMCP server contains severaltry...catchblocks aroundlogger.info()calls.These were added as a defensive measure to ensure logging failures could never disrupt the health check process.
However, upon review, these are unnecessary:
console.error.debugflag is active, otherwise it's a no-op.console.errorthrowing an exception is negligible in a standard Node.js environment.This change removes these
try...catchblocks to improve code clarity and reduce visual clutter, aligning with a "fail fast" principle if the logging mechanism itself were to be fundamentally broken.