LearnNewsExamplesServices
Frontmatter
id7801
titleRefactor services to use config directly instead of DEFAULT_QUERY_LIMITS
stateClosed
labels
enhancementairefactoring
assigneestobiu
createdAtNov 19, 2025, 11:00 AM
updatedAtNov 19, 2025, 11:09 AM
githubUrlhttps://github.com/neomjs/neo/issues/7801
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtNov 19, 2025, 11:09 AM

Refactor services to use config directly instead of DEFAULT_QUERY_LIMITS

Closed v11.6.0 enhancementairefactoring
tobiu
tobiu commented on Nov 19, 2025, 11:00 AM

DEFAULT_QUERY_LIMITS is defined in ai/mcp/server/github-workflow/services/queries/issueQueries.mjs and ai/mcp/server/github-workflow/services/queries/pullRequestQueries.mjs. These constants merely re-map values from ai/mcp/server/github-workflow/config.mjs to query variable names, creating unnecessary indirection.

The config.mjs file should be the single source of truth used directly by the services constructing the queries.

Tasks:

  1. Remove DEFAULT_QUERY_LIMITS from ai/mcp/server/github-workflow/services/queries/issueQueries.mjs.
  2. Update ai/mcp/server/github-workflow/services/IssueService.mjs and ai/mcp/server/github-workflow/services/sync/IssueSyncer.mjs to assign query variables (e.g., maxLabels, maxAssignees) directly from aiConfig.issueSync.
  3. Remove DEFAULT_QUERY_LIMITS from ai/mcp/server/github-workflow/services/queries/pullRequestQueries.mjs.
  4. Update ai/mcp/server/github-workflow/services/PullRequestService.mjs to assign query variables directly from aiConfig.pullRequest (or aiConfig.issueSync where applicable).
tobiu added the enhancement label on Nov 19, 2025, 11:00 AM
tobiu added the ai label on Nov 19, 2025, 11:00 AM
tobiu added the refactoring label on Nov 19, 2025, 11:00 AM
tobiu assigned to @tobiu on Nov 19, 2025, 11:00 AM
tobiu referenced in commit 669f85f - "Refactor services to use config directly instead of DEFAULT_QUERY_LIMITS #7801" on Nov 19, 2025, 11:09 AM
tobiu closed this issue on Nov 19, 2025, 11:09 AM