LearnNewsExamplesServices
Frontmatter
id7812
titleFix regression: Enable HTML rendering in form field labels (valueLabel)
stateClosed
labels
bugrefactoringregression
assigneestobiu
createdAtNov 19, 2025, 3:56 PM
updatedAtNov 19, 2025, 5:08 PM
githubUrlhttps://github.com/neomjs/neo/issues/7812
authortobiu
commentsCount2
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtNov 19, 2025, 5:08 PM

Fix regression: Enable HTML rendering in form field labels (valueLabel)

Closed v11.6.1 bugrefactoringregression
tobiu
tobiu commented on Nov 19, 2025, 3:56 PM

A regression bug was identified in Neo.filter.BooleanContainer. The issue arises from the shift to domApiRenderer as the default in DefaultConfig.mjs. Some setters update vdom.text (mapping to element.textContent) instead of vdom.html. This causes escaped strings (e.g., <i>) to render as text instead of HTML elements.

Specifically, Neo.form.field.CheckBox uses valueLabelText and afterSetValueLabelText, which sets vdom.text.

Proposed Solution:

  1. Refactor Neo.form.field.CheckBox:
    • Rename valueLabelText_ to valueLabel_ (breaking change).
    • Accept either a string or a VDOM object/array.
    • If it's a string, treat it as text.
  2. Update Neo.filter.BooleanContainer to use the new config.
  3. Find and update all usages of valueLabelText across the codebase (src, apps, examples, docs/app).

Affected Files:

  • src/form/field/CheckBox.mjs
  • src/filter/BooleanContainer.mjs
  • All files using valueLabelText config on CheckBox.
tobiu added the bug label on Nov 19, 2025, 3:56 PM
tobiu added the refactoring label on Nov 19, 2025, 3:56 PM
tobiu added the regression label on Nov 19, 2025, 3:56 PM
tobiu
tobiu Nov 19, 2025, 3:57 PM
Image
tobiu assigned to @tobiu on Nov 19, 2025, 3:57 PM
tobiu referenced in commit 64398fb - "Fix regression: Enable HTML rendering in form field labels (valueLabel) #7812" on Nov 19, 2025, 4:52 PM
tobiu
tobiu Nov 19, 2025, 5:08 PM
Image
tobiu closed this issue on Nov 19, 2025, 5:08 PM