LearnNewsExamplesServices
Frontmatter
id7953
titleRefactor Client Configuration Consistency
stateClosed
labels
airefactoring
assigneestobiu
createdAtNov 30, 2025, 4:57 PM
updatedAtNov 30, 2025, 5:02 PM
githubUrlhttps://github.com/neomjs/neo/issues/7953
authortobiu
commentsCount0
parentIssue7931
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtNov 30, 2025, 5:02 PM

Refactor Client Configuration Consistency

Closed v11.14.0 airefactoring
tobiu
tobiu commented on Nov 30, 2025, 4:57 PM

Context

Neo.ai.mcp.client.Client currently has an inconsistent split between static config and class fields. command and args are configs, while openApiFilePath and requiredEnv are fields, despite all four serving the same purpose (configuration derived from serverName or passed manually).

Goal

Normalize the configuration properties in Client.mjs to be consistent.

Requirements

  1. Move openApiFilePath from class field to static config (non-reactive).
  2. Move requiredEnv from class field to static config (non-reactive).
  3. Ensure loadServerConfig updates these properties using this.openApiFilePath = ... (which works for both configs and fields, but for configs it's the proper setter).

Deliverables

  • Cleaned up ai/mcp/client/Client.mjs.
tobiu added the ai label on Nov 30, 2025, 4:57 PM
tobiu added the refactoring label on Nov 30, 2025, 4:57 PM
tobiu assigned to @tobiu on Nov 30, 2025, 4:58 PM
tobiu added parent issue #7931 on Nov 30, 2025, 4:58 PM
tobiu referenced in commit f6d1455 - "Refactor Client Configuration Consistency #7953" on Nov 30, 2025, 5:02 PM
tobiu closed this issue on Nov 30, 2025, 5:02 PM