LearnNewsExamplesServices
Frontmatter
id8109
titleEnhance Legit Viewport UX and Fix WriteFile Signature
stateClosed
labels
bugenhancementairefactoring
assigneestobiu
createdAtDec 13, 2025, 5:06 PM
updatedAtDec 13, 2025, 5:07 PM
githubUrlhttps://github.com/neomjs/neo/issues/8109
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtDec 13, 2025, 5:07 PM

Enhance Legit Viewport UX and Fix WriteFile Signature

Closed v11.17.0 bugenhancementairefactoring
tobiu
tobiu commented on Dec 13, 2025, 5:06 PM

This ticket addresses UX improvements and a necessary API update in the Legit app.

1. Button State Management (UX) To prevent errors during initialization, the "New File" and "Save" buttons must be disabled by default and only enabled once the LegitService is ready.

  • apps/legit/view/Viewport.mjs:

    • Set disabled: true on "New File" button.
    • Set disabled: true on "Save" button.
    • Add reference: 'save-button' to the "Save" button.
  • apps/legit/view/ViewportController.mjs:

    • In initAsync, enable both buttons (new-file-button, save-button) after LegitService.ready() resolves.

2. API Signature Fix (Bug) The LegitService.writeFile method was refactored to use a config object, but the controller calls were not updated.

  • apps/legit/view/ViewportController.mjs:
    • Update onAddFileDialogSave to use {data, path}.
    • Update onSaveButtonClick to use {data, path}.
tobiu added the bug label on Dec 13, 2025, 5:06 PM
tobiu added the enhancement label on Dec 13, 2025, 5:06 PM
tobiu added the ai label on Dec 13, 2025, 5:06 PM
tobiu added the refactoring label on Dec 13, 2025, 5:06 PM
tobiu assigned to @tobiu on Dec 13, 2025, 5:07 PM
tobiu referenced in commit a74681f - "Enhance Legit Viewport UX and Fix WriteFile Signature #8109" on Dec 13, 2025, 5:07 PM
tobiu closed this issue on Dec 13, 2025, 5:07 PM