LearnNewsExamplesServices
Frontmatter
id8153
titleArchitecture: Propagate windowId to StateProviders and Controllers
stateClosed
labels
enhancementaiarchitecture
assigneestobiu
createdAtDec 21, 2025, 5:09 PM
updatedAtDec 21, 2025, 5:13 PM
githubUrlhttps://github.com/neomjs/neo/issues/8153
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtDec 21, 2025, 5:13 PM

Architecture: Propagate windowId to StateProviders and Controllers

Closed v11.17.0 enhancementaiarchitecture
tobiu
tobiu commented on Dec 21, 2025, 5:09 PM

This task ensures that windowId is consistently propagated from Neo.component.Abstract to its associated state.Provider and controller.Component instances.

Requirements:

  1. Neo.state.Provider:

    • Add a windowId config (default null). It does not need to be reactive, as controller.Component already has it as a non-reactive config.
  2. Neo.component.Abstract:

    • Update afterSetWindowId(value, oldValue):
      • If value is defined, propagate it to this.controller.windowId (if the controller exists).
      • If value is defined, propagate it to this.stateProvider.windowId (if the state provider exists).
    • Update beforeSetStateProvider(value, oldValue):
      • Include windowId: this.windowId in the default values object passed to ClassSystemUtil.beforeSetInstance when creating the state provider instance.
tobiu added the enhancement label on Dec 21, 2025, 5:09 PM
tobiu added the ai label on Dec 21, 2025, 5:09 PM
tobiu added the architecture label on Dec 21, 2025, 5:09 PM
tobiu assigned to @tobiu on Dec 21, 2025, 5:09 PM
tobiu referenced in commit 0d2eda6 - "#8153 Propagate windowId to StateProviders and Controllers" on Dec 21, 2025, 5:12 PM
tobiu
tobiu Dec 21, 2025, 5:13 PM

Implemented windowId propagation to state.Provider and controller.Component.

  • Added non-reactive windowId config to state.Provider
  • Updated component.Abstract to propagate windowId changes
  • Updated component.Abstract to pass windowId during state provider creation
  • Fixed JSDoc type for controller.Component.windowId
tobiu closed this issue on Dec 21, 2025, 5:13 PM