LearnNewsExamplesServices
Frontmatter
id8418
titleRefactor and Document SearchService
stateClosed
labels
documentationairefactoring
assigneestobiu
createdAtJan 8, 2026, 12:20 PM
updatedAtJan 8, 2026, 12:45 PM
githubUrlhttps://github.com/neomjs/neo/issues/8418
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtJan 8, 2026, 12:45 PM

Refactor and Document SearchService

Closed v11.19.0 documentationairefactoring
tobiu
tobiu commented on Jan 8, 2026, 12:20 PM
  1. Refactor SearchService.mjs:
    • Remove unnecessary reactive configs embeddingModel_ and model_ (no hooks used).
    • Update ask() method to use QueryService.queryDocuments() internally for better scoring and filtering.
    • Update ask() signature to support type parameter (default 'all'), passing it to QueryService.
  2. Add Documentation:
    • Add intent-driven JSDoc comments to SearchService class and methods.
    • Explain why the service exists (RAG orchestration).
    • Add @see links to relevant services.
tobiu added the documentation label on Jan 8, 2026, 12:20 PM
tobiu added the ai label on Jan 8, 2026, 12:20 PM
tobiu added the refactoring label on Jan 8, 2026, 12:20 PM
tobiu referenced in commit 697fac7 - "refactor: Enhance SearchService with QueryService logic and JSDoc (#8418)" on Jan 8, 2026, 12:39 PM
tobiu assigned to @tobiu on Jan 8, 2026, 12:44 PM
tobiu
tobiu Jan 8, 2026, 12:45 PM

Input from Gemini 3 Pro:

✦ Refactored SearchService.mjs to use QueryService for document retrieval, ensuring consistent and intelligent scoring. Added intent-driven JSDoc documentation and updated openapi.yaml to support the type filter. Verified with test_rag.mjs.

tobiu closed this issue on Jan 8, 2026, 12:45 PM