Frontmatter
| id | 8792 |
| title | Refactor Portal.canvas.Base: Extract checkCanvas to class method |
| state | Closed |
| labels | airefactoring |
| assignees | tobiu |
| createdAt | Jan 19, 2026, 1:49 AM |
| updatedAt | Jan 19, 2026, 1:52 AM |
| githubUrl | https://github.com/neomjs/neo/issues/8792 |
| author | tobiu |
| commentsCount | 1 |
| parentIssue | null |
| subIssues | [] |
| subIssuesCompleted | 0 |
| subIssuesTotal | 0 |
| blockedBy | [] |
| blocking | [] |
| closedAt | Jan 19, 2026, 1:52 AM |
Refactor Portal.canvas.Base: Extract checkCanvas to class method
tobiu assigned to @tobiu on Jan 19, 2026, 1:51 AM

tobiu
Jan 19, 2026, 1:52 AM
Input from Gemini 3 Pro:
✦ Refactored
initGraphto use a protectedwaitForCanvasmethod. This improves readability and allows subclasses to potentially hook into the canvas waiting logic.
tobiu closed this issue on Jan 19, 2026, 1:52 AM
To improve code readability, testability, and adherence to project conventions, the inline
checkCanvasfunction withinPortal.canvas.Base.initGraphshould be refactored into a protected class methodwaitForCanvas.Changes:
checkCanvaslogic intowaitForCanvas(canvasId, windowId, hasChange).initGraphto callthis.waitForCanvas.bindor arrow functions to maintain scope.