LearnNewsExamplesServices
Frontmatter
id9282
titleGrid Row: Propagate theme changes to cell components
stateClosed
labels
bugaicore
assigneestobiu
createdAtFeb 24, 2026, 2:51 AM
updatedAtFeb 24, 2026, 2:53 AM
githubUrlhttps://github.com/neomjs/neo/issues/9282
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtFeb 24, 2026, 2:53 AM

Grid Row: Propagate theme changes to cell components

Closed v12.0.0 bugaicore
tobiu
tobiu commented on Feb 24, 2026, 2:51 AM

When the theme config on a grid changes, Neo.grid.Body properly propagates the new theme to its items (the Neo.grid.Row pool). However, Neo.grid.Row was missing the afterSetTheme hook, meaning any custom components rendered inside the grid cells (e.g. Sparkline widgets) were not notified of the theme change.

Resolution:

  • Added afterSetTheme(value, oldValue) to src/grid/Row.mjs.
  • The method iterates over this.components (the cached instances of column components) and sets component.theme = value, ensuring deep propagation of the theme switch to all cell widgets.
tobiu added the bug label on Feb 24, 2026, 2:52 AM
tobiu added the ai label on Feb 24, 2026, 2:52 AM
tobiu added the core label on Feb 24, 2026, 2:52 AM
tobiu assigned to @tobiu on Feb 24, 2026, 2:52 AM
tobiu referenced in commit 2c5c596 - "fix(grid): Propagate theme changes to cell components (#9282) on Feb 24, 2026, 2:52 AM
tobiu
tobiu Feb 24, 2026, 2:53 AM

The fix has been implemented and pushed to the dev branch.

tobiu closed this issue on Feb 24, 2026, 2:53 AM