LearnNewsExamplesServices
Frontmatter
id9307
titleResolve naming clash for Icon/IconLink column iconCls
stateClosed
labels
bugai
assigneestobiu
createdAtFeb 26, 2026, 2:32 PM
updatedAtFeb 26, 2026, 2:37 PM
githubUrlhttps://github.com/neomjs/neo/issues/9307
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtFeb 26, 2026, 2:37 PM

Resolve naming clash for Icon/IconLink column iconCls

Closed v12.0.0 bugai
tobiu
tobiu commented on Feb 26, 2026, 2:32 PM

Problem: When using Icon or IconLink column types in a grid, configuring an iconCls for the cell icons inadvertently overwrites the column header's sorting arrow icon. This is because the grid container uses the column's configuration object to instantiate both the cell components and the header buttons.

Proposed Solution: Introduce a new config cellIconCls specifically for the cell-level components, allowing iconCls to remain the domain of the header button (if desired).

  • src/grid/column/IconLink.mjs: Replace iconCls config with cellIconCls. Update applyRecordConfigs to map cellIconCls to iconCls for the underlying Neo.component.IconLink.
  • src/grid/column/Icon.mjs: Replace iconCls config with cellIconCls. Update applyRecordConfigs to map cellIconCls to iconCls for the underlying Neo.component.Icon.
  • apps/devindex/view/home/GridContainer.mjs: Update configurations to use cellIconCls instead of iconCls.
tobiu added the bug label on Feb 26, 2026, 2:32 PM
tobiu added the ai label on Feb 26, 2026, 2:32 PM
tobiu referenced in commit 51ed988 - "fix(grid): Resolve naming clash for Icon/IconLink column iconCls (#9307)" on Feb 26, 2026, 2:36 PM
tobiu
tobiu Feb 26, 2026, 2:36 PM

Input from Gemini 3.1 Pro:

✦ I have implemented the change across both the components (Neo.component.Icon, Neo.component.IconLink) and the grid column definitions (Neo.grid.column.Icon, Neo.grid.column.IconLink), renaming the config from iconCls to cellIconCls. The GridContainer inside DevIndex has also been updated. The changes have been pushed to the dev branch.

tobiu assigned to @tobiu on Feb 26, 2026, 2:36 PM
tobiu closed this issue on Feb 26, 2026, 2:37 PM