LearnNewsExamplesConnect
Frontmatter
assigneesneo-opus-grace
createdAtNov 6, 2026, 12:53 PM
updatedAtNov 8, 2026, 2:24 PM
githubUrlhttps://github.com/neomjs/neo/issues/20451
authorneo-opus-grace
commentsCount2
parentIssue20328
subIssues[]
subIssuesCompleted0
subIssuesTotal0
contentTrust
projected
quarantined0
signals[]
blockedBy[x] 20376 Off-socket NL dispatch for SharedWorker apps, [x] 20374 CI selection runs single-app NL specs without a Brain checkout
blocking[]
closedAtNov 8, 2026, 2:24 PM

The Brain-gated e2e tier retires once no Engine spec needs the bridge

Closed v13.4.0/archive-v13-4-0-chunk-4 airefactoringtestingtech-debt
neo-opus-grace
neo-opus-grace commented on Nov 6, 2026, 12:53 PM

Context

@tobiu, 2026-11-06, verbatim: "NL is split to the engine side (processing arriving tool calls), and the brain side: bridge and tool definitions. both sides on their own can get tested inside each repo (we already do this). a full e2e cycle: i can not see any reasonable way, that is not heavy hitting on CI."

The Brain-gated tier (test-e2e-brain.yml) is that full cycle. Every Engine run of it checks out the Brain and drives Neural Link specs through the Brain's bridge. In #20328's baseline it holds 66% of Engine CI runner-minutes. Discussion D#18775 already chose the replacement: an off-socket adapter, so that Neural Link specs drive the page's own App Worker with no bridge and no Brain checkout. #20370 owns that track:

The Problem

None of those leaves removes the tier itself. Without a retirement task, the workflow, the Brain checkout and the Brain-only selection code would stay after their last spec moves. That is the pattern this morning's rule forbids: logic needs a task that uses it and then retires it.

The Fix

Once #20374 and #20376 have landed:

  • Every Neural Link spec that still needs the bridge is either ported to the off-socket adapter or retired with its reason. The Brain tests its own bridge and tool definitions.
  • Delete .github/workflows/test-e2e-brain.yml and the classifier's Brain outputs: e2e_brain_tier, plus e2e_brain_paths, e2e_brain_matrix and e2e_brain_shards from #20411. Delete the brain branch of tierSelection() and FULL_SHARDS.brain with them.
  • Delete the Brain-only selection and receipt code in buildScripts/util/e2eCiSelection.mjs (BRAIN_*, brain* functions) and the exclusion in test/playwright/externalBrainSelection.mjs, together with their specs.
  • Remove any remaining Brain checkout from Engine workflows.

Acceptance Criteria

  • No Engine workflow checks out neomjs/neo-agent-brain. A git grep over .github/workflows shows it, with a control.
  • Every Neural Link spec runs off-socket in the engine tier, or stays local with a written reason. At dev b2f505e6e3, selectExternalBrainSpecs gates 71 of 209 e2e specs. By the markers in their source:
    • 46 drive windows;

    • 4 hold multi-writer Bridge sessions (bridgePort, waitForSession);

    • 2 import Brain services (loadNeuralLinkModules);

    • 19 carry no marker: #20461's three residuals, plus 16 first candidates.

    • The window rule was policy, not a capability limit. The adapter forwards every window tool (Euclid, 11-08), and an app's popups share its SharedWorker. A local off-socket probe of the 42 window-driving files ran 37 clean, workstation/WorkstationFilmTourNL among them. #19919 folded in here: its hop 4 refusal was classified as film-harness timing.

    • Outcome (PR #20584). 54 specs join the engine tier:

      • the 16 candidates;
      • 36 of the 37 clean window specs;
      • the residuals WorkstationNestedColumnResizeNL and WorkstationMaximizeTabOverflowNL.

      The 37th, WorkstationFilmTourNL, runs off-socket but flaked hosted. One throw in four carried no momentum (474 of 960 px), so it is a declared EXCLUSIONS entry owned by #20593.

      The other 16 are declared in LOCAL_ONLY (buildScripts/util/e2eCiSelection.mjs) with their reasons, and the selection floor refuses a Neural Link spec that sits in neither list. The 16:

      • 4 Bridge specs;
      • 6 Brain-service specs;
      • 6 window specs that fail on the adapter and pass over the Bridge, owned by #20587. One of them is the residual DockSplitterZoneIdNL, which fails off-socket after a re-boot.
  • The Brain-only selection, receipt and exclusion code is deleted together with its specs. The deletion commits carry spec-retired: accounts.
  • Engine CI runner-minutes per PR drop measurably against #20328's baseline.

Moving a spec into the engine tier

  • It joins ADAPTER_ELIGIBLE_SPECS and leaves LOCAL_ONLY, and it joins RUN_PATHS wherever its directory is not listed whole. The selection floor fails otherwise.
  • e2eEngineDurations.json rebuilds through --engine-durations. A file the table has not measured counts at the median.
  • e2e-engine is a required context, so a moved spec needs a hosted green first.
  • Later moves ship under their own tickets (#20587).

Out of Scope

  • The off-socket adapters themselves (#20370, #20374, #20376).
  • Brain-side bridge and tool-definition tests, which belong to the Brain repository.

Related

#20328 (parent), #20370, #20374, #20376, #20450, #20411.

Live sweep, 2026-11-06 ~11:55Z: latest open issues plus an all-state search for "retire Brain-gated tier". No equivalent was found.

Unblocked: #20374 and #20376 landed (#20404, #20461). #19919's film-tour finding folds in here, since its open criteria (hosted reliability and shard room) belong to the tier this ticket retires.

Origin Session ID: a33fc3c4-7e98-4300-985d-25a10e216b50 Retrieval Hint: "retire Brain-gated e2e tier off-socket Neural Link no Brain checkout full cycle"

🖖 Grace (Opus 5.5, Claude Code)